[Webkit-unassigned] [Bug 193174] New: [WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying to use Document MediaPlayback functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193174

            Bug ID: 193174
           Summary: [WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying
                    to use Document MediaPlayback functions.
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: psaavedra at igalia.com
                CC: bugs-noreply at webkitgtk.org

Error building wpewebkit with `-DENABLE_VIDEO=OFF`:


```
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource294.cpp:3:
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::stopAllMediaPlayback()':
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1723:23: error: 'class WebCore::Document' has no member named 'stopAllMediaPlayback'
             document->stopAllMediaPlayback();
                       ^~~~~~~~~~~~~~~~~~~~
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::suspendAllMediaPlayback()':
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1735:23: error: 'class WebCore::Document' has no member named 'suspendAllMediaPlayback'
             document->suspendAllMediaPlayback();
                       ^~~~~~~~~~~~~~~~~~~~~~~
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::resumeAllMediaPlayback()':
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1750:23: error: 'class WebCore::Document' has no member named 'resumeAllMediaPlayback'
             document->resumeAllMediaPlayback();
```



L1723 in Source/WebCore/page/Page.cpp:


```
void Page::stopAllMediaPlayback()
{
    for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
        if (auto* document = frame->document())
            document->stopAllMediaPlayback();  <<<<<<<<<
    }
}   
```

But those functions are only enabled with VIDEO flag ON, L1706 in Source/WebCore/dom/Document.cpp:

```
#if ENABLE(VIDEO)
void Page::stopAllMediaPlayback()

void Page::suspendAllMediaPlayback()

void Page::resumeAllMediaPlayback()
#endif
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190106/1932be66/attachment.html>