[Webkit-unassigned] [Bug 192451] Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 15:30:56 PST 2019
https://bugs.webkit.org/show_bug.cgi?id=192451
Devin Rousso <drousso at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #358372|review? |review+
Flags| |
--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358372
--> https://bugs.webkit.org/attachment.cgi?id=358372
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=358372&action=review
r=me, nice fix :)
One thing I just noticed (not sure if this is new) is that switching from "JavaScript Allocations" to "Memory" to "JavaScript & Events" causes the path components of "JavaScript Allocations" to briefly appear before switching to those of "JavaScript & Events". Probably uses a rAF to update?
> Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js:97
> + if (this._contentView.shouldSaveStateOnHide) {
NIT: I'd call this `shouldSaveStateWhenHidden`. I usually don't like shorter prepositions in names (e.g. using `Did` instead of the past tense).
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190104/dbd058d7/attachment.html>
More information about the webkit-unassigned
mailing list