[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 03:24:47 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #53 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 363211
  --> https://bugs.webkit.org/attachment.cgi?id=363211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363211&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:319
> +    if (firstParty == url)

Checking URLs seems useless. How about checking hosts?
if (firstParty.host() == url.host())

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:360
> +    if (!checkCookieAcceptPolicy(firstParty, requestUrl))

I think this condition should be moved after the following condition "if (requestHost.isEmpty())" for efficiency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190228/9fc1b051/attachment.html>


More information about the webkit-unassigned mailing list