[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 01:20:34 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #49 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #31)
> > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:122
> > +    if (auto cookies = cookieJarDB.searchCookies(firstParty, url, WTF::nullopt, WTF::nullopt, WTF::nullopt)) {
> 
> This is a bug fix for a separate issue. Does this bug have a actual problem
> in WinCairo port?
> 

I will fix this bug as a separate issue.
So in this patch takes searchCookie(firstParty, firstParty, ...)

> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:395
> > +            pstmt->bindText(5, String("*.") + registrableDomain.string());
> 
> These code should match with the one of CookieJarDB::hasCookies.
>

Do you mean to use registrableDoman to bindText(4) ?
hasCookies() should check cookie existence of eTLD+1. But searchCookies() is not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190228/af189a87/attachment.html>


More information about the webkit-unassigned mailing list