[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #43 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.h:44
> +enum class CookieAcceptPolicy {
> +    Always,
> +    Never,
> +    OnlyFromMainDocumentDomain,
> +    ExclusivelyFromMainDocumentDomain
> +};

Why not just use the existing HTTPCookieAcceptPolicy enum?

> Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:56
> +    m_process.forEachNetworkStorageSession([curlPolicy] (const auto& networkStorageSession) {
> +        networkStorageSession.cookieStorage().setCookieAcceptPolicy(networkStorageSession, curlPolicy);
> +    });

If my patch in bug #195140 lands first, then you'll need to change this to something like:

if (auto* networkStorageSession = m_process.networkStorageSession())
    networkStorageSession.cookieStorage().setCookieAcceptPolicy(networkStorageSession, curlPolicy);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190228/865052a7/attachment.html>