[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 14:50:02 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #40 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

>>>>>> Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:-29
>>>>>> -#if ENABLE(PUBLIC_SUFFIX_LIST)
>>>>> 
>>>>> This ENABLE(PUBLIC_SUFFIX_LIST) check should be kept. It's common in WebKit to have ENABLE checks in their respective implementaion files.
>>>> 
>>>> I don't think so because this is a curl port specific file and all curl ports are defining ENABLE_PUBLIC_SUFFIX_LIST.
>>> 
>>> Isn't that also the case for PublicSuffixMac.mm and PublicSuffixSoup.cpp? Those files also have the enable check. I'm not sure what we gain by removing the check in this file and removing it makes disabling the flag on curl more involved.
>> 
>> I get your idea. I don't have a strong opinion. Other *Curl.cpp files are using "#if USE(CURL)". How about it?
> 
> This is the long lasting question for me. Why do Curl implementation file check the USE(CURL)?

Yeah I guess cmake handles USE(CURL) for curl implementation files. I think for this case, these files don't depend on libcurl and aren't implementing curl network layer abstractions so I'm not sure if USE(CURL) applies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190227/28f2e734/attachment.html>


More information about the webkit-unassigned mailing list