[Webkit-unassigned] [Bug 194830] [WPE] Do not create a PlatformDisplay in the Service Worker process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194830

--- Comment #10 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Zan Dobersek from comment #8)
> Comment on attachment 362973 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362973&action=review
> 
> > Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:95
> > -void WebProcessPool::platformInitializeWebProcess(WebProcessCreationParameters& parameters)
> > +void WebProcessPool::platformInitializeWebProcess(WebProcessCreationParameters& parameters, bool isServiceWorkerProcess)
> >  {
> >  #if PLATFORM(WPE)
> > -    parameters.hostClientFileDescriptor = wpe_renderer_host_create_client();
> > +    if (!isServiceWorkerProcess)
> > +        parameters.hostClientFileDescriptor = wpe_renderer_host_create_client();
> 
> Instead of the extra bool parameter to this method, there should be an extra
> bool variable `isServiceWorkerProcess` added to WebProcessCreationParameters
> for the WPE port. It would be initialized in
> WebProcessPool::initializeNewWebProcess() before the
> platformInitializeWebProcess() call.

So in WebProcessPool::initializeNewWebProcess :
#if PLATFORM(WPE) && ENABLE(SERVICE_WORKER)
    parameters.isServiceWorkerProcess = process.isServiceWorkerProcess();
#endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190227/b965dd74/attachment-0001.html>