[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #37 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

>>> Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:-29
>>> -#if ENABLE(PUBLIC_SUFFIX_LIST)
>> 
>> This ENABLE(PUBLIC_SUFFIX_LIST) check should be kept. It's common in WebKit to have ENABLE checks in their respective implementaion files.
> 
> I don't think so because this is a curl port specific file and all curl ports are defining ENABLE_PUBLIC_SUFFIX_LIST.

Isn't that also the case for PublicSuffixMac.mm and PublicSuffixSoup.cpp? Those files also have the enable check. I'm not sure what we gain by removing the check in this file and removing it makes disabling the flag on curl more involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190227/71d38ac2/attachment.html>