[Webkit-unassigned] [Bug 195049] Fix warnings on ARM and MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195049

--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362986
  --> https://bugs.webkit.org/attachment.cgi?id=362986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

>>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
>>> +            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());
>> 
>> Let's use bitwise_cast here too.
> 
> Why?
> My preference of casting is:
> 1. static_cast
> 2. bitwise_cast
> 3. reinterpret_cast

I just wasn't thinking correctly.  I guess static_cast does a compile time type check, and hence, is preferable to bitwise_cast which only does a size check.  I withdraw my comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190226/10168afb/attachment.html>