[Webkit-unassigned] [Bug 195049] Fix warnings on ARM and MIPS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 14:06:42 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=195049

--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362986
  --> https://bugs.webkit.org/attachment.cgi?id=362986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
>> +            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());
> 
> Let's use bitwise_cast here too.

Why?
My preference of casting is:
1. static_cast
2. bitwise_cast
3. reinterpret_cast

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190226/fa681de1/attachment.html>


More information about the webkit-unassigned mailing list