[Webkit-unassigned] [Bug 193806] [PlayStation] Upstream playstation's remote inspector server

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 16:14:21 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193806

--- Comment #31 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 362388
  --> https://bugs.webkit.org/attachment.cgi?id=362388
Inspector Server

View in context: https://bugs.webkit.org/attachment.cgi?id=362388&action=review

>> Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketPlayStation.cpp:271
>> +            m_inspectorClient->didAccept(newID.value(), DomainType::Inet);
> 
> Nit: You could call the client without the lock.

I think this case is okay, the lock is already released before the createClient call.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190226/d24c6248/attachment-0001.html>


More information about the webkit-unassigned mailing list