[Webkit-unassigned] [Bug 194923] AX: Treat AXChildrenInNavigationOrder as AXChildren before adding support for aria-flowto

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194923

--- Comment #10 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 362772
  --> https://bugs.webkit.org/attachment.cgi?id=362772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362772&action=review

> Source/WebCore/ChangeLog:8
> +        AXChildrenInNavigationOrder returns different array of elements than that from AXChildren for AppKit. This is because currently WebKit doesn't support AXChildrenInNavigationOrder, and though AppKit's fallback, AppKit reorder them based on horizontal positions. Added this temporary support for WebKit so that AppKit doesn't reorder them.

can you break this up on smaller lines?

> LayoutTests/accessibility/mac/children-in-navigation-order-returns-children.html:37
> +        shouldBe("children1.length", "2");

I think the 2 children in this div might be the same role already. what if you added a button in here to ensure there were different objects

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190223/bb4892a7/attachment.html>