[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 01:15:45 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #25 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362684
  --> https://bugs.webkit.org/attachment.cgi?id=362684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362684&action=review

Bug 194791 is going to change all call site of topPrivatelyControlledDomain. I think you should wait for landing the patch.

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:122
> +    if (auto cookies = cookieJarDB.searchCookies(firstParty, firstParty, WTF::nullopt, WTF::nullopt, WTF::nullopt)) {

Why don't you pass the fourth argument (URL) to the second parameter of searchCookies?
See the implementations of other ports. They are using the fourth argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190222/e1f0a046/attachment.html>


More information about the webkit-unassigned mailing list