[Webkit-unassigned] [Bug 194923] AX: Treat AXChildrenInNavigationOrder as AXChildren before adding support for aria-flowto

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194923

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362662|review?                     |review-
              Flags|                            |

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 362662
  --> https://bugs.webkit.org/attachment.cgi?id=362662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362662&action=review

> Source/WebCore/ChangeLog:10
> +        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

can you add a description for why you're doing this

also can you add a test that verifies that children is the same as children in navigation order

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:156
> +#ifndef NSAccessibilityChildrenInNavigationOrderAttribute

this is defined as a private attribute so we should make this available through a SPI.h file

See 
/Volumes/data/web/OpenSource/Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h

for example

and it should go in
/Volumes/data/web/OpenSource/Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190222/36cbb2d9/attachment.html>