[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #21 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 362484
  --> https://bugs.webkit.org/attachment.cgi?id=362484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362484&action=review

> Tools/TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:91
>  }

Oh, I'm sorry, you've already have that. I don't think these refactoring is good. Unit test should be simple, easy to read even if it seems verbose. Think about this. As time goes by, the test grows. We will see the test which has different firstParty and url (of course it should). Then we have to see both test line and variable. We don't get any clue from test result output.

Better way to manage the test with bunch of data set is using value parameterized tests. (https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#value-parameterized-tests).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190220/0aa5348f/attachment.html>