[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #18 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #12)
> Comment on attachment 362288 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362288&action=review
> 
> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:457
> > +bool CookieJarDB::canAcceptCookie(const Cookie& cookie, const String& firstParty, const String& host, CookieJarDB::Source source)
> 
> It seems that canAcceptCookie should take a URL instead of host to avoid
> unnecessary string building.

Fixed to use URL.

> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:472
> > +    URL cookieDomainUrl({ }, makeString("http://", cookieDomain));
> 
> checkCookieAcceptPolicy takes String argument at the moment. Why do you
> convert String to URL?

Fixed. In new patch arguments of checkCookieAcceptPolicy and searchCookies are changed to URL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190220/73f7d64e/attachment.html>