[Webkit-unassigned] [Bug 194819] Fix crash when opening Web Inspector after a WebSocket was blocked by content extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194819

--- Comment #10 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Joseph Pecoraro from comment #9)
> Comment on attachment 362415 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362415&action=review
> 
> r=me, thanks for finding, fixing, and including a test!!
> 
> Let me know if you need me to set the commit-queue flag.
If you are OK with the test, yes (I wasn't sure if it was the proper way, there isn't anything to test on the frontend side since blocked WebSockets are not displayed in the Network tab).
> 
> > LayoutTests/http/tests/inspector/network/contentextensions/blocked-websocket-crash.html:20
> > +        test(resolve, reject) {
> > +            // The inspector won't receive anything, so there is nothing to expect.
> > +            // The test just makes sure the inspector initialization is done
> > +	    resolve();
> > +	}
> 
Oops, mixed tabs and spaces.
> Indentation got a little messed up here. But perhaps we should do something
> to just verify that things worked. How about:
> 
>     suite.addTestCase({
>         name: "Network.BlockedRequests.WebSocket",
>         description: "Ensure Web Inspector works even with a blocked
> WebSocket connection",
>         test(resolve, reject) {
>             InspectorTest.pass("Web Inspector initialized.");
>             resolve();
>         }
>     });
OK, this is perhaps a little more clear like this, with a test status in the output (even if there already would be a timeout without the resolve()).
I would still write "after a blocked WebSocket connection" instead of "with ...", since it's important : there was no issue if the inspector is opened before the connection is blocked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190219/d014e3f8/attachment.html>