[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #12 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362288
  --> https://bugs.webkit.org/attachment.cgi?id=362288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362288&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:457
> +bool CookieJarDB::canAcceptCookie(const Cookie& cookie, const String& firstParty, const String& host, CookieJarDB::Source source)

It seems that canAcceptCookie should take a URL instead of host to avoid unnecessary string building.

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:472
> +    URL cookieDomainUrl({ }, makeString("http://", cookieDomain));

checkCookieAcceptPolicy takes String argument at the moment. Why do you convert String to URL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190219/427046ce/attachment.html>