[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #10 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362288
  --> https://bugs.webkit.org/attachment.cgi?id=362288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362288&action=review

> Source/WebCore/ChangeLog:16
> +               LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html

Remove "LayoutTests/".

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:122
> +    if (auto cookies = cookieJarDB.searchCookies(firstParty.string())) {

IIUC, this should call five arguments version of searchCookies.
CookieJarDB::searchCookies(const String& firstParty, const String& requestUrl, const Optional<bool>& httpOnly, const Optional<bool>& secure, const Optional<bool>& session)

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:310
> +bool CookieJarDB::checkCookieAcceptPolicy(const String& firstParty, const String& url)

It seems better to take the arguments as URL instead of String. How do you think?

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:338
> +    // Set same url not to call checkCookieAcceptPolicy() infinitely.

I think searchCookies should be renamed instead of having this comment. For example, searchCookiesByUrl or hasCookies?

> Source/WebCore/platform/network/curl/CookieUtil.cpp:93
> +#else

Why do we need the code for !ENABLE(PUBLIC_SUFFIX_LIST)? It seems that AppleWin is the only port not enabling PUBLIC_SUFFIX_LIST. I think we can assume ENABLE(PUBLIC_SUFFIX_LIST) in libcurl integration.

> LayoutTests/platform/wincairo/TestExpectations:939
> +http/tests/security/cookies/third-party-cookie-blocking.html [ Pass Failure ]

"[ Pass Failure ]" means these tests are flaky. Do you know the reason why these tests are failing so flaky?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190219/316a18e2/attachment.html>