[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 09:55:32 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191303

--- Comment #59 from darshan <dkadu at igalia.com> ---
(In reply to Darin Adler from comment #55)
> Comment on attachment 362238 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362238&action=review
> 
> > Tools/DumpRenderTree/TestOptions.cpp:161
> > +            RELEASE_ASSERT_NOT_REACHED();
> 
> This is not "reporting" unknown options, it's *aborting* if passed an
> unknown option. That doesn’t seem like a good interface for a command line
> tool.

Idea was to fail the tests with unknown options. Getting the proper message why its failing would be the ideal solution for this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190218/20d0dfaa/attachment.html>


More information about the webkit-unassigned mailing list