[Webkit-unassigned] [Bug 194772] [ARM] Fix crash with sampling profiler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194772

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362276|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362276
  --> https://bugs.webkit.org/attachment.cgi?id=362276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362276&action=review

r=me with fix.

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:181
> +        if (dest == ARMRegisters::sp) {

This is incorrect.  You only need this alternative codegen if (dest == ARMRegisters::sp && src != dest).  If (dest == ARMRegisters::sp && src == dest), the implementation below would generate more optimal code.  For details, see add(RegisterID rd, RegisterID rn, ARMThumbImmediate imm) in ARMv7Assembler.h.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190218/c3b8434b/attachment.html>