[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 07:57:25 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191303

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #55 from Darin Adler <darin at apple.com> ---
Comment on attachment 362238
  --> https://bugs.webkit.org/attachment.cgi?id=362238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362238&action=review

> Tools/DumpRenderTree/TestOptions.cpp:161
> +            RELEASE_ASSERT_NOT_REACHED();

This is not "reporting" unknown options, it's *aborting* if passed an unknown option. That doesn’t seem like a good interface for a command line tool.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190218/e87583b2/attachment-0001.html>


More information about the webkit-unassigned mailing list