[Webkit-unassigned] [Bug 194499] [GStreamer][MSE] Seek while seeking freezes playback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 14 12:33:27 PST 2019
https://bugs.webkit.org/show_bug.cgi?id=194499
--- Comment #1 from Alicia Boya GarcĂa <aboya at igalia.com> ---
Thank you for your report and your testcase.
I can reproduce the stall indeed. On the other hand, I can't not reproduce the fix. I made this change, making hasBufferedTime() behave the same as isTimeBuffered().
--- a/Source/WebCore/Modules/mediasource/MediaSource.cpp
+++ b/Source/WebCore/Modules/mediasource/MediaSource.cpp
@@ -374,14 +374,7 @@ bool MediaSource::contentTypeShouldGenerateTimestamps(const ContentType& content
bool MediaSource::hasBufferedTime(const MediaTime& time)
{
- if (time > duration())
- return false;
-
- auto ranges = buffered();
- if (!ranges->length())
- return false;
-
- return abs(ranges->nearest(time) - time) <= currentTimeFudgeFactor();
+ return buffered()->contain(time);
}
bool MediaSource::hasCurrentTime()
After building and running the test, I noticed no difference. Indeed in both cases there is this line in the logs:
0:00:02.545226604 3505 0x13afef0 DEBUG webkitmse MediaPlayerPrivateGStreamerMSE.cpp:263:doSeek: [Seek] Delaying the seek: In async change PAUSED --> PAUSED
This implies doSeek() returns before actually reaching any call to isTimeBuffered().
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190214/76522f17/attachment.html>
More information about the webkit-unassigned
mailing list