[Webkit-unassigned] [Bug 194642] Web Inspector: remove unused parameter in _parseStylePropertyPayload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 23:22:55 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=194642

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #361996|review?                     |review+
              Flags|                            |

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361996
  --> https://bugs.webkit.org/attachment.cgi?id=361996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361996&action=review

rs=me, it took a minute to understand what you meant by _this_ in "used by this method", but I see what you mean.  The `styleText` parameter was never used :P

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:509
> +    _parseStylePropertyPayload(payload, index, styleDeclaration)

There should also (technically) be a ChangeLog entry for this.

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:665
> +            var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration);

Style: `let`.

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:669
> +        var text = payload.cssText;

Style: `let`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190214/bb776373/attachment-0001.html>


More information about the webkit-unassigned mailing list