[Webkit-unassigned] [Bug 194590] New: Do not silently disable GIR for cross builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194590

            Bug ID: 194590
           Summary: Do not silently disable GIR for cross builds
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CMake
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rasmus.thomsen at protonmail.com

Hello,

Could the silent disabling of GIR in OptionsGTK.cmake be removed? Void Linux has recently enabled GIR compilation in cross builds using the methods already used by the Yocto Project and Buildroot (namely running g-ir-* through qemu), so we have to patch it out:

--- Source/cmake/OptionsGTK.cmake.orig  2019-02-10 18:04:07.898417778 +0100
+++ Source/cmake/OptionsGTK.cmake       2019-02-10 18:04:36.673415569 +0100
@@ -357,7 +357,6 @@
 # Override the cached variables, gtk-doc and gobject-introspection do not really work when cross-building.
 if (CMAKE_CROSSCOMPILING)
     set(ENABLE_GTKDOC OFF)
-    set(ENABLE_INTROSPECTION OFF)
 endif ()

 # Override the cached variable, gtk-doc does not really work when building on Mac.


The cross builds work fine for us now on armv{5,6,7} and aarch64.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190213/3799ef3b/attachment.html>