[Webkit-unassigned] [Bug 194586] Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 02:19:46 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=194586

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
DumpJSConsoleLogInStdErr expectation is considered a bad idea by some developers.
And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027).
So, I'd like to remove DumpJSConsoleLogInStdErr expectation and use dumpJSConsoleLogInStdErr test option instead.

(In reply to Jonathan Bedard from bug #194283 comment #3)
> This bug very much confuses me. Why would we have a test expectation with
> DumpJSConsoleLogInStdErr in it? That feels like an abuse of the
> TestExpectations.

(In reply to Alexey Proskuryakov from bug #194283 comment #2)
> I think that we are hitting a design mistake with regards to
> DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with
> expectations causes trouble.

(In reply to youenn fablet from bug #161310 comment #4)
> It seems a bit odd to add that keyword to TestExpectations since it is
> becoming more like a setup option. This applies also a bit to Slow keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190213/e62ff6e2/attachment.html>


More information about the webkit-unassigned mailing list