[Webkit-unassigned] [Bug 193806] [PlayStaton] Upstream playstation's remote inspector server

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 11:55:06 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193806

--- Comment #17 from Christopher Reid <chris.reid at sony.com> ---
(In reply to Build Bot from comment #16)
> Attachment 361701 [details] did not pass style-queue:
> 
> 
> ERROR:
> Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocket.h:
> 37:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR:
> Source/JavaScriptCore/inspector/remote/playstation/
> RemoteInspectorSocketPlayStation.cpp:34:  Alphabetical sorting problem. 
> [build/include_order] [4]
> Total errors found: 2 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I believe the style bot is wrong here https://webkit.org/code-style-guidelines/#include-system

This patch is also ready for a more in depth review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190211/4eaaf208/attachment-0001.html>


More information about the webkit-unassigned mailing list