[Webkit-unassigned] [Bug 194433] Compute fixed position rect based on scrolling tree view of the current scroll position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194433

--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 361515
  --> https://bugs.webkit.org/attachment.cgi?id=361515
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361515&action=review

> Source/WebCore/ChangeLog:12
> +        This patch removes code that that passes the last committed scroll position via the state tree and modifies its only
> +        client (in ScrollingTreeScrollingNodeDelegateIOS) to use the UIScrollView scrolling position.

How does this work with FixedPositionViewportConstraints::layerPositionForViewportRect((), which uses viewportRectAtLastLayout and layerPositionAtLastLayout, which you haven't changed? ScrollingTreeFrameScrollingNode::fixedPositionRect() uses the committed scroll position, which should match viewportRectAtLastLayout. Or maybe these are never used in the same code path?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190211/7e833f3c/attachment.html>