[Webkit-unassigned] [Bug 194494] [WPE] Send client host fd and library name as web process creation parameters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194494

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 361666
  --> https://bugs.webkit.org/attachment.cgi?id=361666
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361666&action=review

>> Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:53
>> +    if (!parameters.implementationLibraryName.isNull())
> 
> isEmpty() here, should avoid potential problems of passing empty strings to wpe_loader_init().

It's a CString not a String, so we don't have isEmpty there. We could explicitly check data()[0] != '\0' but I don't think it's needed for something sent the from the UI process. The only reason we are checking this is because wpe_loader_get_loaded_implementation_library_name() is new api, so when libwpe < 0.2 we receive a null string here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190211/ab2c7ae9/attachment.html>