[Webkit-unassigned] [Bug 194414] New: REGRESSION(r240784): [MSE][GStreamer] MSE tests became flaky on debug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194414

            Bug ID: 194414
           Summary: REGRESSION(r240784): [MSE][GStreamer] MSE tests became
                    flaky on debug
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK+
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aboya at igalia.com
                CC: bugs-noreply at webkitgtk.org

I'm getting flaky failures where "updateend" is received when "update" was expected. These seem to occur only in Debug, and after bisecting for a while I found the first bad commit to be this:

commit 90b22c6ed58ea31072568656d08f047cd86bd82f (refs/bisect/bad)
Author: aboya at igalia.com <aboya at igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jan 31 14:54:52 2019 +0000

    [MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
    https://bugs.webkit.org/show_bug.cgi?id=194067

    Reviewed by Xabier Rodriguez-Calvar.

    A couple methods in AppendPipeline were returning GstFlowReturn
    despite there being no codepath (sans assertions) where values other
    than GST_FLOW_OK are returned.

    Therefore, it makes sense to just make these methods return void.

Which is a commit that was not intended to introduce behavior changes, but something may have slipped anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190207/eb32cd89/attachment.html>