[Webkit-unassigned] [Bug 194344] [WTF] Add getting/changing current working directory to FileSystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194344

--- Comment #4 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Christopher Reid from comment #2)
> Comment on attachment 361321 [details]
> Add get/change current working directory functions
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361321&action=review


> > Source/WTF/wtf/posix/FileSystemPOSIX.cpp:500
> > +        return "";
> 
> Should we return Optional<String> to avoid something like
> getCurrentWorkingDirectory() + "/file.txt" inadvertently attempt to create a
> file in the root?

I'd chosen just returning String because that's what homeDirectoryPath was doing, but making it an Optional is probably better. Will change, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190207/e705d207/attachment.html>