[Webkit-unassigned] [Bug 194344] [WTF] Add getting/changing current working directory to FileSystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194344

--- Comment #2 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 361321
  --> https://bugs.webkit.org/attachment.cgi?id=361321
Add get/change current working directory functions

View in context: https://bugs.webkit.org/attachment.cgi?id=361321&action=review

> Source/WTF/wtf/glib/FileSystemGlib.cpp:470
> +    return stringFromFileSystemRepresentation(g_get_current_dir());

I think this leaks the returned string. The glib docs for g_get_current_dir states "The returned string should be freed when no longer needed"

> Source/WTF/wtf/posix/FileSystemPOSIX.cpp:500
> +        return "";

Should we return Optional<String> to avoid something like getCurrentWorkingDirectory() + "/file.txt" inadvertently attempt to create a file in the root?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190207/f571c0fd/attachment.html>