[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191303

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361201|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #38 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 361201
  --> https://bugs.webkit.org/attachment.cgi?id=361201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361201&action=review

> Tools/DumpRenderTree/TestOptions.h:49
> +    bool enableCSSCustomPropertiesAndValues { false };

Please address add a FIXME:

(In reply to Frédéric Wang (:fredw) from comment #36)
> Currently the new values are not used at all, so you should add a FIXME and
> open a separate bug if you don't plan to fix that in this bug.
> 
> For Web Preferences, you can probably get the default values from
> Source/WebKit/Shared/WebPreferences.yaml and only need to initialize them in
> setWebPreferencesForTestOptions from
> Tools/DumpRenderTree/mac/DumpRenderTree.mm

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190205/d81ba08f/attachment-0001.html>