[Webkit-unassigned] [Bug 194259] New: rotationDidEndCallback not triggered on iPad during testing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 17:09:52 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=194259

            Bug ID: 194259
           Summary: rotationDidEndCallback not triggered on iPad during
                    testing
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jbedard at apple.com
                CC: lforschler at apple.com

This causes the following tests to fail:
    fast/events/ios/rotation/basic-rotation.html [ Skip ]
    fast/events/ios/rotation/layout-viewport-during-rotation.html [ Skip ]
    fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html [ Skip ]
    fast/events/ios/rotation/resize-iframe-after-orientation-change.html [ Skip ]
    fast/events/ios/rotation/safari-like-rotation.html [ Skip ]

In particular, the callback in this function never gets triggered during iPad testing:

void UIScriptController::simulateRotation(DeviceOrientation* orientation, JSValueRef callback)
{
    TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView();
    webView.usesSafariLikeRotation = NO;

    unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);

    webView.rotationDidEndCallback = ^{
        if (!m_context)
            return;
        m_context->asyncTaskComplete(callbackID);
    };

    [[UIDevice currentDevice] setOrientation:toUIDeviceOrientation(orientation) animated:YES];
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190205/998734e2/attachment.html>


More information about the webkit-unassigned mailing list