[Webkit-unassigned] [Bug 193919] [GTK] Implement back/forward touchpad gesture
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 4 13:03:46 PST 2019
https://bugs.webkit.org/show_bug.cgi?id=193919
--- Comment #72 from Tim Horton <thorton at apple.com> ---
Comment on attachment 361074
--> https://bugs.webkit.org/attachment.cgi?id=361074
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=361074&action=review
> Source/WebKit/Shared/SessionState.h:28
> +#if PLATFORM(COCOA) || PLATFORM(GTK)
Now that it's not in /Cocoa you can just include it unconditionally
> Source/WebKit/UIProcess/ViewGestureController.h:32
> +#if PLATFORM(GTK)
> +#include <WebCore/CairoUtilities.h>
> +#endif
Conditional includes should be in their own paragraph down below
> Source/WebKit/UIProcess/ViewGestureController.h:170
> + void draw(cairo_t*, cairo_pattern_t*);
Probably stick this before the `// Testing` section
> Source/WebKit/UIProcess/ViewSnapshotStore.h:69
> +#else
Shouldn't most of these #else's be #elif PLATFORM(GTK) to make it easier to add more platforms later?
> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:46
> +static const double swipeOverlayShadowGradientOffsets[] = { 0, 0.03125, 0.0625, 0.0938, 0.125, 0.1875, 0.25, 0.375, 0.4375, 0.5, 0.5625, 0.625, 0.6875, 0.75, 0.875, 1. };
> +static const double swipeOverlayShadowGradientAlpha[] = { 1, 0.99, 0.98, 0.95, 0.92, 0.82, 0.71, 0.46, 0.35, 0.25, 0.17, 0.11, 0.07, 0.04, 0.01, 0. };
Do you really want the modern-macOS-style gradients? That is surprising!
> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:77
> +bool ViewGestureController::PendingSwipeTracker::scrollEventCanBecomeSwipe(GdkEventScroll *event, ViewGestureController::SwipeDirection& potentialSwipeDirection)
I wonder if we can factor some more of this out into shared code (a variant of this that just takes deltas, which scrollEventCanBecomeSwipe calls after extracting the deltas from the event, for example)
> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:105
> +bool ViewGestureController::PendingSwipeTracker::handleEvent(GdkEventScroll *event)
Ditto
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190204/ecadbcec/attachment.html>
More information about the webkit-unassigned
mailing list