[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191303

--- Comment #36 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 360913
  --> https://bugs.webkit.org/attachment.cgi?id=360913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360913&action=review

> Tools/ChangeLog:10
> +        Added and assigned testoptions which are currently used in tests.

test options

> Tools/DumpRenderTree/TestOptions.cpp:117
> +            experimentalCSSCustomPropertiesAndValuesEnabled = parseBooleanTestHeaderValue(value);

Looking at the rest of the code, it seems keys starting with "experimental:" and "internal:" don't include the prefix in the variable name. Also it seems that sometimes the variable name is of the form enableXXX rather than XXXEnabled (although that's not very consistent).

> Tools/DumpRenderTree/TestOptions.h:49
> +    bool experimentalCSSCustomPropertiesAndValuesEnabled { false };

Ideally, you should check that the default value is consistent with the rest of the code (especially what is used by the WebKiTestRunner). Have you tried to do a search to see how the values are initialized elsewhere?

Currently the new values are not used at all, so you should add a FIXME and open a separate bug if you don't plan to fix that in this bug.

For Web Preferences, you can probably get the default values from Source/WebKit/Shared/WebPreferences.yaml and only need to initialize them in setWebPreferencesForTestOptions from Tools/DumpRenderTree/mac/DumpRenderTree.mm

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190204/9f7673d9/attachment-0001.html>