[Webkit-unassigned] [Bug 194201] [GTK] Allow pinch zoom on touchpad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194201

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361011|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 361011
  --> https://bugs.webkit.org/attachment.cgi?id=361011
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361011&action=review

Does this depend on the other patch? If not, you can request cq? for commit-queue.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1202
> +    if (event->type == GDK_TOUCHPAD_PINCH) {
> +        WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
> +        GestureController& controller = webkitWebViewBaseGestureController(webViewBase);
> +        controller.handleEvent(event);
> +    }

Style: just do it on one line:

if (event->type == GDK_TOUCHPAD_PINCH)
    webkitWebViewBaseGestureController(WEBKIT_WEB_VIEW_BASE(widget)).handleEvent(event);

In C it would be too hard to read if we don't use multiple lines, but this is C++. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190203/6ceb306c/attachment.html>