[Webkit-unassigned] [Bug 194143] Unable to move selection into editable roots with 0 height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194143

--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
We can almost get away with changing that check to this:

  if (block.logicalHeight() || m_anchorNode->isRootEditableElement()) {
      …
  }

...but that causes a couple of problems, as observed in our editing tests. The following two tests:

  editing/pasteboard/datatransfer-items-copy-html.html
  editing/execCommand/indent-no-visible-contents-crash.html

...exercise scenarios in which the potential visible position's anchor node is the body element, but is also non-editable, so isRootEditableElement() returns false. We can fix these tests by doing this instead:

  if (block.logicalHeight() || is<HTMLBodyElement>(m_anchorNode) || m_anchorNode->isRootEditableElement()) {
      …
  }

However, there's a third test failure I have yet to figure out: editing/pasteboard/styled-element-markup.html...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190202/5c9ca333/attachment.html>