[Webkit-unassigned] [Bug 194186] New: LocalAuthenticator::getAssertion attempts to put an NSData into a string using %s

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194186

            Bug ID: 194186
           Summary: LocalAuthenticator::getAssertion attempts to put an
                    NSData into a string using %s
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: darin at apple.com

When converting code to remove uses of String::format, I noticed this misuse:

    m_connection->getUserConsent(
        String::format("Log into %s with %s.", requestData().requestOptions.rpId.utf8().data(), selectedCredentialAttributes[(id)kSecAttrApplicationTag]),
        (__bridge SecAccessControlRef)selectedCredentialAttributes[(id)kSecAttrAccessControl],
        WTFMove(callback));

selectedCredentialAttributes[(id)kSecAttrApplicationTag] returns an NSData *, which can't be usefully formatted with %s.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190202/9ce0f8e7/attachment.html>