[Webkit-unassigned] [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193878

--- Comment #31 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 360930
  --> https://bugs.webkit.org/attachment.cgi?id=360930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360930&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:56
> +        result = true;

it looks like you can replace the usage of bool result with just a AXNotification directly

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:59
> +    Ref<Document> document(m_renderer->document());

document appears to be unused

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:60
> +    if (cache)

you can do

if (auto cache = axObjectCache())
   cache->

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190202/5b2d51ef/attachment.html>