[Webkit-unassigned] [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193878

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360903|review?                     |review-
              Flags|                            |

--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 360903
  --> https://bugs.webkit.org/attachment.cgi?id=360903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360903&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:52
> +        RenderMenuList* menuList = downcast<RenderMenuList>(renderer());
> +        if (menuList->popupIsVisible())

You should use is<RenderMenuList>(renderer()) here; is<> does the type check and the null pointer check for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190201/e9b76988/attachment-0001.html>