[Webkit-unassigned] [Bug 194171] Web Inspector: Make WI.ColumnChart a WI.View subclass

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194171

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #360890|review?                     |review+
              Flags|                            |

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360890
  --> https://bugs.webkit.org/attachment.cgi?id=360890
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360888&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:51
> +        this._svgElement = this.element.appendChild(createSVGElement("svg"));

I think it's worth adding `preservesAspectRatio="none"` like many of the other charts, so that if we ever use it elsewhere it also supports stretching.

    this._svgElement.setAttribute("preserveAspectRatio", "none");

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190201/b875c727/attachment-0001.html>