[Webkit-unassigned] [Bug 194169] New: Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194169

            Bug ID: 194169
           Summary: Web Inspector: REGRESSION: clicking a selected call
                    frame doesn't re-scroll
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

# Steps to reproduce:
1. inspect <https://webkit.org>
2. set a breakpoint on global.js:2
3. reload the page
4. select the "Global Code" call frame
5. select the "(anonymous function)" call frame
6. scroll down so that the highlighted line isn't visible
7. re-select (e.g. click again) the "(anonymous function)" call frame

# Expected result:
The view should scroll to the line highlighted in step 6.

# Actual result:
The view doesn't scroll at all.

# Notes:
I believe this regressed with the addition of `WI.SelectionController`.  `WI.SelectionController.prototype.selectItem` early-returns if the index is already selected, meaning we don't call `selectionControllerSelectionDidChange` (which therefore doesn't fire `WI.TreeOutline.Event.SelectionDidChange`).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190201/66e6bff4/attachment.html>