[Webkit-unassigned] [Bug 194146] [WPE] MiniBrowser: use g_file_new_for_commandline_arg

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 02:02:25 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=194146

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #3)
> Comment on attachment 360850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360850&action=review
> 
> > Tools/MiniBrowser/wpe/main.cpp:206
> > +        GFile* file = g_file_new_for_commandline_arg(uriArguments[0]);
> > +        char* url = g_file_get_uri(file);
> 
> I'd recommend using smart pointers for this

We can't. MiniBrowser uses only the public API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190201/c77c24e5/attachment.html>


More information about the webkit-unassigned mailing list