[Webkit-unassigned] [Bug 205648] New: REGRESSION(r253939): [GTK] Broke build with !USE(WPE_RENDERER)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205648

            Bug ID: 205648
           Summary: REGRESSION(r253939): [GTK] Broke build with
                    !USE(WPE_RENDERER)
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, dino at apple.com,
                    sam at webkit.org
            Blocks: 205604

r253939 broke the build in the Debian stable bot:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/28184

This bot checks that WebKit its buildable with the libraries shipped by the distribution.
libwpe is still not shipped by Debian stable, so it builds with --cmakeargs=-DUSE_WPE_RENDERER=OFF

The build error from gcc is a bit cryptic, so I tried to build it locally with clang instead of gcc and I can see this:

In file included from ../../Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:46:
In file included from DerivedSources/ForwardingHeaders/WebCore/Extensions3DOpenGL.h:28:
In file included from DerivedSources/ForwardingHeaders/WebCore/Extensions3DOpenGLCommon.h:31:
In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsContext3D.h:31:
DerivedSources/ForwardingHeaders/WebCore/GraphicsContext3DBase.h:734:9: error: expected identifier
        None,
        ^
/usr/include/X11/X.h:115:30: note: expanded from macro 'None'
#define None                 0L /* universal null resource or null atom */


It seems there is a conflict because of using the word "None", which a X11 header defines to 0L.

This X11 header is included when !USE(WPE_RENDERER) from

In file included from Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:32:
In file included from /usr/include/EGL/egl.h:39:
In file included from /usr/include/EGL/eglplatform.h:124:
In file included from /usr/include/X11/Xlib.h:44:


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=205604
[Bug 205604] [WebGL] Add a pure virtual base class for GraphicsContext3D
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191230/3c6a844c/attachment.htm>