[Webkit-unassigned] [Bug 205520] ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205520

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 386424
  --> https://bugs.webkit.org/attachment.cgi?id=386424
Fix one more expectations file

View in context: https://bugs.webkit.org/attachment.cgi?id=386424&action=review

I’d like to say review+ -- the part of this that corrects types from integer to float seems obviously correct -- but I don’t know enough to be sure this is exactly OK as is.

> Source/WebCore/ChangeLog:3
> +        ANGLE: Fix WebGL conformance tests for EXT_texture_filter_anisotropic

It’s a bit ambiguous or imprecise to title a patch that fixes behavior of the web engine "fix conformance tests". It’s not the tests we are fixing!

> Source/WebCore/ChangeLog:17
> +        * html/canvas/WebGL2RenderingContext.cpp:
> +        (WebCore::WebGL2RenderingContext::getExtension):
> +        (WebCore::WebGL2RenderingContext::getSupportedExtensions):
> +        (WebCore::WebGL2RenderingContext::getParameter):
> +        * html/canvas/WebGLRenderingContext.cpp:
> +        (WebCore::WebGLRenderingContext::getExtension):
> +        * html/canvas/WebGLRenderingContextBase.cpp:
> +        (WebCore::WebGLRenderingContextBase::getTexParameter):

It would be nice to have comments that explain what the changes are.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:-1372
> -    ENABLE_IF_REQUESTED(EXTTextureFilterAnisotropic, m_extTextureFilterAnisotropic, "WEBKIT_EXT_texture_filter_anisotropic", enableSupportedExtension("GL_OES_texture_float"_s));

What mitigates the risk of removing this? Is this possibly incompatible with WebKit-specific content, such as content embedded in iOS apps, that does not work with other web engines?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-144
> -    ENABLE_IF_REQUESTED(EXTTextureFilterAnisotropic, m_extTextureFilterAnisotropic, "WEBKIT_EXT_texture_filter_anisotropic", enableSupportedExtension("GL_EXT_texture_filter_anisotropic"_s));

What mitigates the risk of removing this? Is this possibly incompatible with WebKit-specific content, such as content embedded in iOS apps, that does not work with other web engines?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191227/0605c44e/attachment-0001.htm>