[Webkit-unassigned] [Bug 205449] Allow Vectors as hash keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205449

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 386102
  --> https://bugs.webkit.org/attachment.cgi?id=386102
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386102&action=review

> Source/WTF/ChangeLog:22
> +        Add traits. Empty Vector is the empty value.

I see this now. I’m not a huge fan of this. What if there is a scenario where empty vector is a legit key? Maybe just make the empty value Max - 1 and nullptr

> Source/WTF/wtf/Vector.h:670
> +        : Base(0, -1)

Should we use numeric_limits Max for cleanliness?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191219/33b444fc/attachment-0001.htm>