[Webkit-unassigned] [Bug 205290] Nullptr crash in WebCore::findPlaceForCounter with display: contents parent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205290

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 386017
  --> https://bugs.webkit.org/attachment.cgi?id=386017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386017&action=review

> Source/WebCore/ChangeLog:3
> +        Null Ptr Deref in WebCore::findPlaceForCounter

Please update this line to match the bug title.

> LayoutTests/ChangeLog:3
> +        Null Ptr Deref in WebCore::findPlaceForCounter

Ditto.

> LayoutTests/fast/css/counters/findPlaceForCounter-crash.html:13
> +<p> Bug <a href="https://bugs.webkit.org/show_bug.cgi?id=205290">205290</a>: Crash in WebCore::findPlaceForCounter</p>
> +<p> This test PASSES if it does not CRASH or ASSERT.</p>

I don't think where the crash used to happen would be a useful information.
We should just say:
This tests an element with CSS counter having a parent with display: contents.
The test passes if WebKit doesn't crash or hit an assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191219/619e41fa/attachment-0001.htm>