[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
I agree with Adrian that this is a good idea:

(In reply to Adrian Perez from comment #12)
>  * If the theme name is “<name>-dark”:
>     - Remove the “-dark” suffix, use “<name>” as the theme.
>     - If the theme “<name>” does not exist, GTK automatically
>       fall-back to Adwaita.
>  * Otherwise:
>     - Keep the current theme name, assuming that it is light.
> 
> This matches the on-going discussion about the proposal started around
> the last GUADEC where dark themes should be required to have a “-dark”
> suffix.

Then we need to revert the change from bug #196685 and have PageClientImpl::effectiveAppearanceIsDark always return false. And then we can close this bug, and all related dark mode bugs.

In the future, it would be nice to actually support dark mode, but it's clear at this point we can't do that in GTK, so it must be preconditioned on removal of GTK theme support and implementation of a cross-platform theme that doesn't use GTK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191217/4714b74e/attachment.htm>