[Webkit-unassigned] [Bug 201507] [GTK] Accelerated compositing is disabled due to failure in EGL display creation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201507

--- Comment #36 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Michael Catanzaro from comment #33)
> I notice my EGL doesn't support EGL_EXT_image_dma_buf_import_modifiers, but
> it looks like that shouldn't be causing any failure here.

Mmmm....

If your EGL doesn't support that, then s_eglQueryDmaBufModifiersEXT() is NULL.
It seems also s_eglQueryDmaBufFormatsEXT() would be NULL in that case (looking at the if-code block guarding it, it only enters into it if both extensions are supported).

The code block you pasted here checks for that, but below that code, in Instance::foreachDmaBufModifier() it calls both s_eglQueryDmaBufModifiersEXT() and s_eglQueryDmaBufFormatsEXT() and doesn't seem to check the function pointers are valid.

https://github.com/Igalia/WPEBackend-fdo/blob/bee4104/src/ws.cpp#L534

may this explain your issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191217/ed92ff9e/attachment-0001.htm>